fix(java): use client-class-name for exception type in README#14045
Merged
fix(java): use client-class-name for exception type in README#14045
Conversation
Co-Authored-By: judah <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
fern-support
approved these changes
Mar 25, 2026
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
client-class-nameis specified in the Java generator custom config, the v1 generator creates an exception class named{clientClassName}ApiException. However, the v2 README generator was ignoringclient-class-nameand always using{org}ApiException(viagetBaseNamePrefix()), causing the README's exception handling snippet to reference a class that doesn't exist in the SDK.Changes Made
getApiExceptionClassName()inSdkGeneratorContext.tsto checkclient-class-namebefore falling back togetBaseNamePrefix(), matching v1's logic inClientPoetClassNameFactory.getApiErrorClassName()Priority chain is now:
base-api-exception-class-name(explicit override) — unchangedclient-class-name+"ApiException"— newgetBaseNamePrefix()+"ApiException"(org-based default) — unchangedHuman Review Checklist
ClientPoetClassNameFactory.getApiErrorClassName()atgenerators/java/sdk/src/main/java/com/fern/java/client/ClientPoetClassNameFactory.java:160-167client-class-nameawareness is missing in other v2 naming methods (e.g.,getBaseExceptionClassNameequivalent if one exists)Testing
Link to Devin session: https://app.devin.ai/sessions/3cb0ef910a644cf7b635abc52e59943b
Requested by: @jsklan